New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for image criticality at image onload to fix carousel display #938

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

In 1.7, images are checked for criticality when the onload event fires.  If 
there's a carousel or similar UX above the fold, the visible images may change 
before onload leading to inconsistent results (and in the worst case the actual 
first image on the page never accumulating enough support to be considered 
critical).

We should make sure to check image criticality at image onload time as well, as 
this will reflect the state of the page when the image arrives.  This can be 
combined on the client side with criticality at page onload to get a truer 
picture of which images qualify as above the fold.

Original issue reported on code.google.com by jmaes...@google.com on 1 May 2014 at 6:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment