Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Commit 9da85bb

Browse files
committed
Replace CHECK with return failure and log.
Fixes #888 along with https://code.google.com/p/modpagespeed/source/detail?r=4533
1 parent 90ac91f commit 9da85bb

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/ngx_pagespeed.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1816,7 +1816,10 @@ ngx_int_t ps_resource_handler(ngx_http_request_t* r,
18161816
GoogleString url_string = ps_determine_url(r);
18171817
GoogleUrl url(url_string);
18181818

1819-
CHECK(url.IsWebValid());
1819+
if (!url.IsWebValid()) {
1820+
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, "invalid url");
1821+
return NGX_DECLINED;
1822+
}
18201823

18211824
scoped_ptr<RequestHeaders> request_headers(new RequestHeaders);
18221825
scoped_ptr<ResponseHeaders> response_headers(new ResponseHeaders);

0 commit comments

Comments
 (0)