ngx_brotli compression support ? #1021
Comments
Verified:
My guess is that PageSpeed is seeing the html brotli encoded and doesn't know how to decode it. Ideally the brotli decoding would happen after PageSpeed, like gzip encoding. I need to build this to test it. |
does the order of execution of the modules change this behavior? eg |
That would make sense, except the command they used is:
I think either their config or our config needs to change to get the order we want. I think it's us? We have:
And brotli runs before gzip. So I think what we need is:
I haven't tested this though. |
@jeffkaufman On trunk-tracking, we also have a8141ea From the nginx forum [1]:
[1] http://forum.nginx.org/read.php?2,152699,152727#msg-152727 |
|
@jeffkaufman: maybe inject pagespeed filter right after postpone filter instead of right before gzip? |
or maybe you could just echo and inspect $HTTP_FILTER_MODULES values and check for ngx_brotli module if it exists, sed replacement after ngx_http_brotli_filter_module module instead of after $HTTP_GZIP_FILTER_MODULE - would just be a simple IF or ELSE ? basically
|
Reported by George Liu (eva2000) on GitHub (issue apache#1021). Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Reported by George Liu (eva2000) on GitHub (issue #1021). Signed-off-by: Piotr Sikora <piotrsikora@google.com> Conflicts: config
I just compiled Nginx ngx_brotli module support into my Nginx server https://community.centminmod.com/posts/19601/ with ngx_pagespeed enabled.
Problem:
Content-Encoding: "br"
- non-working as in no resources are pagespeed optimisedusing following ngx_brotli directives
The text was updated successfully, but these errors were encountered: