Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPRO responses sometimes forward a bad cache control value #1138

Closed
oschaaf opened this issue Feb 27, 2016 · 5 comments
Closed

IPRO responses sometimes forward a bad cache control value #1138

oschaaf opened this issue Feb 27, 2016 · 5 comments

Comments

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Feb 27, 2016

Cloudflare sometimes shows an error page when serving an mp3 file. It does so when it receives a bad header that looks like: Cache-Control: ?ax-age, as seen in error.log.

The server is running ngx_pagespeed 1.10.33.5

@oschaaf
Copy link
Member Author

@oschaaf oschaaf commented Feb 27, 2016

@oschaaf
Copy link
Member Author

@oschaaf oschaaf commented Feb 27, 2016

The bad cache control header is emitted when we hit the flow where IPRO does not find a cache entry and subsequently starts recording the response. In this flow the original cache-control header is passed on which is owned by an NgxBaseFetch instance that will be released the passed on string is put on the wire. The fix is to copy the value, pull coming up.

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Feb 27, 2016

Thanks for tracking this down, Otto. Is this related to specifying a threadpool in nginx?

@oschaaf
Copy link
Member Author

@oschaaf oschaaf commented Feb 27, 2016

@jmarantz No this is unrelated to specifying a threadpool in nginx, though I was looking into both things at the same time because initially I though they might be related.

@jeffkaufman
Copy link
Contributor

@jeffkaufman jeffkaufman commented Mar 3, 2016

Fixed with #1139 and 5264647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants