Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

In amp pages inline_google_font_css must be disabled #1382

Closed
Lofesa opened this issue Feb 17, 2017 · 5 comments
Closed

In amp pages inline_google_font_css must be disabled #1382

Lofesa opened this issue Feb 17, 2017 · 5 comments

Comments

@Lofesa
Copy link

Lofesa commented Feb 17, 2017

When the filter inline_google_font_css is enabled, amp pages throw an error in amp test because the label <style> is not allowed but must be <style amp-custom> so in amp pages the filter must be disabled or label changed

@morlovich morlovich self-assigned this Feb 17, 2017
@morlovich
Copy link
Contributor

Looks like only a single amp-custom is permitted, and we might not be able to tell if there is another one, so likely the best we can do is just autodisable...

@Lofesa
Copy link
Author

Lofesa commented Feb 21, 2017

Disabled better than make a rule to disable it in server config

@jansent
Copy link

jansent commented Feb 22, 2017

+1 on this. It'd be great if there was an easy way to combine the inlined font with the amp-custom inlined styles, or alternatively if amp spec was updated to allow for deferred styles or better support for their own fonts.

morlovich added a commit to apache/incubator-pagespeed-mod that referenced this issue Mar 8, 2017
morlovich added a commit to apache/incubator-pagespeed-mod that referenced this issue Mar 8, 2017
* Disable CSS (really font CSS in practice) inlining on AMP.

Ref: apache/incubator-pagespeed-ngx#1382

* Try to deflake the font inlining test some
@morlovich
Copy link
Contributor

Should be fixed with that.

@jansent
Copy link

jansent commented Mar 8, 2017

Wow thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants