Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx 1.13.4 ‘ngx_http_core_try_files_phase’ was not declared in this scope #1451

Closed
centminmod opened this issue Aug 8, 2017 · 31 comments
Closed

Comments

@centminmod
Copy link

@centminmod centminmod commented Aug 8, 2017

Another nginx 1.13.4 release which broke ngx_pagespeed compilations.

-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib \
-shared
../ngx_pagespeed-1.12.34.2-beta/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
../ngx_pagespeed-1.12.34.2-beta/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
   while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/svr-setup/nginx-1.13.4'
make: *** [build] Error 2

configure options

./configure --with-ld-opt="-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib" --with-cc-opt="-m64 -march=native -DTCP_FASTOPEN=23 -g -O3 -Wno-error=strict-aliasing -fstack-protector-strong -flto -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wno-deprecated-declarations -gsplit-dwarf" --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --with-libatomic --with-http_gzip_static_module --add-dynamic-module=../ngx_brotli --add-dynamic-module=../ngx_pagespeed-1.12.34.2-beta --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.0 --add-module=../ngx_cache_purge-2.3 --add-module=../ngx_devel_kit-0.3.0 --add-module=../set-misc-nginx-module-0.31 --add-module=../echo-nginx-module-0.60 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-module=../headers-more-nginx-module-0.32 --with-pcre=../pcre-8.41 --with-pcre-jit --with-zlib=../zlib-1.2.11 --with-http_ssl_module --with-http_v2_module --with-http_v2_hpack_enc --with-openssl=../libressl-2.6.0

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Aug 8, 2017

Thanks for the report. It seems the breaking change was in nginx/nginx@129b06d

Looking at the specifics, it don't think it's going to be hard to address on our side.

@fmunteanu
Copy link

@fmunteanu fmunteanu commented Aug 8, 2017

@oschaaf Otto, please let us know if there is a quick patch we could apply to fix the issue? 😃

@CWelshE
Copy link

@CWelshE CWelshE commented Aug 8, 2017

@fmunteanu I just used --nginx-version '1.13.3' instead of --nginx-version latest until this issue is solved

@fmunteanu
Copy link

@fmunteanu fmunteanu commented Aug 8, 2017

@CWelshE Cody, I'm not familiar with this switch? I run the Nginx build with .configure --add-dynamic-module=ngx_pagespeed-1.12.34.2-stable

@noogen
Copy link

@noogen noogen commented Aug 9, 2017

Also saw this build error on Ubuntu 16.04. Sticking with 1.13.3 in my build too, for now.

@AnoopAlias
Copy link

@AnoopAlias AnoopAlias commented Aug 9, 2017

Same error

     ngx_pagespeed-1.12.34.2-stable/src/ngx_message_handler.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
 -grecord-gcc-switches -m64 -mtune=generic  -D_GLIBCXX_USE_CXX11_ABI=0 -Wno-unused-local-typedefs -Wno-error -Wno-deprecated-declarations -DNDK_SET_VAR -DNDK_UPSTREAM_LIST --std=c++11 -I
 src/core -I src/event -I src/event/modules -I src/os/unix -I ngx_pagespeed-1.12.34.2-stable/psol/include -I ngx_pagespeed-1.12.34.2-stable/psol/include/third_party/chromium/src -I ngx_p
agespeed-1.12.34.2-stable/psol/include/third_party/google-sparsehash/src/src -I ngx_pagespeed-1.12.34.2-stable/psol/include/third_party/google-sparsehash/gen/arch/linux/x64/include -I ng
x_pagespeed-1.12.34.2-stable/psol/include/third_party/grpc/src/include -I ngx_pagespeed-1.12.34.2-stable/psol/include/third_party/protobuf/src/src -I ngx_pagespeed-1.12.34.2-stable/psol/
include/third_party/re2/src -I ngx_pagespeed-1.12.34.2-stable/psol/include/out/Release/obj/gen -I ngx_pagespeed-1.12.34.2-stable/psol/include/out/Release/obj/gen/protoc_out/instaweb -I n
gx_pagespeed-1.12.34.2-stable/psol/include/third_party/apr/src/include -I ngx_pagespeed-1.12.34.2-stable/psol/include/third_party/aprutil/src/include -I ngx_pagespeed-1.12.34.2-stable/ps
ol/include/third_party/apr/gen/arch/linux/x64/include -I ngx_pagespeed-1.12.34.2-stable/psol/include/third_party/aprutil/gen/arch/linux/x64/include -I ngx_pagespeed-1.12.34.2-stable/psol
/include/url -I /usr/local/rvm/gems/ruby-2.4.1/gems/passenger-5.1.7/src -I ngx_brotli/deps/brotli/include -I ngx_devel_kit-0.3.0/objs -I objs/addon/ndk -I ngx_devel_kit-0.3.0/src -I ngx_
devel_kit-0.3.0/objs -I objs/addon/ndk -I /opt/nDeploy-libmodsecurity/include/ -I ./pcre-8.41 -I ./libressl-2.5.5/.openssl/include -I ./zlib-1.2.11 -I objs -I src/http -I src/http/module
s -I src/http/v2 -I ngx_devel_kit-0.3.0/src -I src/stream \
        -o objs/addon/src/ngx_pagespeed.o \
        ngx_pagespeed-1.12.34.2-stable/src/ngx_pagespeed.cc
ngx_pagespeed-1.12.34.2-stable/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
ngx_pagespeed-1.12.34.2-stable/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
   while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
@fmunteanu
Copy link

@fmunteanu fmunteanu commented Aug 9, 2017

@greg-md, what is the switch @CWelshE is referring to? --nginx-version '1.13.3'

@injust
Copy link

@injust injust commented Aug 9, 2017

@fmunteanu That's the switch for the automated install at https://modpagespeed.com/doc/build_ngx_pagespeed_from_source.

@greg-md
Copy link

@greg-md greg-md commented Aug 9, 2017

@fmunteanu yes, I was installing it from source as @injust mentioned, so this helped.

oschaaf added a commit that referenced this issue Aug 10, 2017
Compilation of ngx_pagespeed broke with the following commit in
nginx: nginx/nginx@129b06d

This change intends to unbreak it while maintaining backwards
compatibility.

Fixes #1451
oschaaf added a commit that referenced this issue Aug 10, 2017
* Compilation of ngx_pagespeed broke with the following commit in
nginx: nginx/nginx@129b06d
This change intends to unbreak it while maintaining backwards
compatibility.

* updates the nginx testing-dependency to 1.13.4

Fixes #1451
@oschaaf
Copy link
Member

@oschaaf oschaaf commented Aug 10, 2017

For those who want to try out the candidate fix: #1453
(diff: https://patch-diff.githubusercontent.com/raw/pagespeed/ngx_pagespeed/pull/1453.diff)

@fmunteanu
Copy link

@fmunteanu fmunteanu commented Aug 10, 2017

@oschaaf Otto, I confirm the patch works beautifully. Thanks for your support!

@injust
Copy link

@injust injust commented Aug 10, 2017

@oschaaf Can also confirm that patch is working as intended. Thank you!

@centminmod
Copy link
Author

@centminmod centminmod commented Aug 10, 2017

@oschaaf thanks confirmed working patch as well 👍

@AminZoubaa
Copy link

@AminZoubaa AminZoubaa commented Aug 11, 2017

@oschaaf you are my hero tonight. I can confirm too, that it's working 👍

@kozhin
Copy link

@kozhin kozhin commented Aug 13, 2017

@oschaaf, thanks for your support! 👍 When do you plan to release this fixed version?

@harichristian
Copy link

@harichristian harichristian commented Aug 20, 2017

@oschaaf you save my day 👍

oschaaf added a commit that referenced this issue Aug 21, 2017
* Compilation of ngx_pagespeed broke with the following commit in
nginx: nginx/nginx@129b06d
This change intends to unbreak it while maintaining backwards
compatibility.

* updates the nginx testing-dependency to 1.13.4

Fixes #1451
@lilmike
Copy link

@lilmike lilmike commented Sep 4, 2017

Is there a planned release timeline for the fixed version? I'm currently holding back nginx-mainline on my arch linux server, but it's only a matter of time until the built 1.13.3 package from arch becomes unable to run because they upgrade a required library or something.
Thanks!
-Michael.

@Eckybrazzz
Copy link

@Eckybrazzz Eckybrazzz commented Sep 24, 2017

The install with bash <(curl -f -L -sS https://ngxpagespeed.com/install) --nginx-version '1.13.3' works just fine but when calling the page I get `ERROR

The requested URL could not be retrieved

The following error was encountered while trying to retrieve the URL: http://techlabshost.com/

Connection to 34.235.174.83 failed.

The system returned: (111) Connection refused

The remote host or network may be down. Please try the request again.

Your cache administrator is root.

Generated Sun, 24 Sep 2017 10:08:04 GMT by newyork-s02-i01 (squid/3.5.26)`

This happens on an Amazon instance, The normal apt-get install nginx works fine.

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 25, 2017

Update -- we are working on an ngx_pagespeed-only point release for this.

oschaaf added a commit that referenced this issue Sep 25, 2017
* Compilation of ngx_pagespeed broke with the following commit in
nginx: nginx/nginx@129b06d
This change intends to unbreak it while maintaining backwards
compatibility.

Fixes #1451
oschaaf added a commit that referenced this issue Sep 28, 2017
* Compilation of ngx_pagespeed broke with the following commit in
nginx: nginx/nginx@129b06d
This change intends to unbreak it while maintaining backwards
compatibility.

Fixes #1451
@oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 28, 2017

Another update: ngx_pagespeed 1.12.34.3-stable was just released, and contains a change to address this issue: https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/9r2QSTepg9E

@noogen
Copy link

@noogen noogen commented Sep 28, 2017

What about the existing of the file https://dl.google.com/dl/page-speed/psol/1.12.34.3-x64.tar.gz or https://dl.google.com/dl/page-speed/psol/1.12.34.3.tar.gz from the pagespeed download instruction here https://www.modpagespeed.com/doc/build_ngx_pagespeed_from_source?

psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
@oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 29, 2017

@noogen For building ngx_pagespeed 1.12.34.3 you actually need to use https://dl.google.com/dl/page-speed/psol/1.12.34.2-x64.tar.gz, because it is an nginx-only release.
I'll make an update to the docs to pull the right version, thanks for pointing this out.

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 29, 2017

@noogen testing this, the documented install process work fine for me. It pulls the right psol version from the PSOL_BINARY_URL file. Could you post more information about the problem you ran in to?

@centminmod
Copy link
Author

@centminmod centminmod commented Oct 1, 2017

cheers works here

nginx -V
nginx version: nginx/1.13.5
built by gcc 4.8.5 20150623 (Red Hat 4.8.5-16) (GCC)
built with LibreSSL 2.5.5
TLS SNI support enabled

configure arguments: --with-ld-opt='-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib' --with-cc-opt='-m64 -march=native -DTCP_FASTOPEN=23 -g -O3 -fstack-protector-strong --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -gsplit-dwarf' --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --add-dynamic-module=../nginx-module-vts --with-libatomic --with-http_gzip_static_module --add-dynamic-module=../ngx_pagespeed-1.12.34.3-stable --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.0 --add-module=../ngx_cache_purge-2.4.2 --add-module=../ngx_devel_kit-0.3.0 --add-dynamic-module=../set-misc-nginx-module-0.31 --add-dynamic-module=../echo-nginx-module-0.61 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-dynamic-module=../headers-more-nginx-module-0.32 --with-pcre=../pcre-8.41 --with-pcre-jit --with-zlib=../zlib-1.2.11 --with-http_ssl_module --with-http_v2_module --with-openssl=../libressl-2.5.5

@noogen
Copy link

@noogen noogen commented Oct 1, 2017

Sorry, the build works for me with psol/1.12.34.2-x64.tar.gz too. Thanks.

@ghost
Copy link

@ghost ghost commented Oct 11, 2017

Hi guys
NginX 1.13.6 > ngx_pagespeed 1.12.34.3-stable > PSOL 1.12.34.2-x64.tar.gz trows this error
/nginx/modules/nginx_pagespeed/src/ngx_server_context.cc
/nginx/modules/nginx_pagespeed/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
/nginx/modules/nginx_pagespeed/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
objs/Makefile:2228: recipe for target 'objs/addon/src/ngx_pagespeed.o' failed

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Oct 11, 2017

@Reborns the line numbers for nps 1.12.34.3 don't seem to match.. can you post the commands leading up to the error?

@ghost
Copy link

@ghost ghost commented Oct 11, 2017

@oschaaf
Like this ?

cc -c -fPIC -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/nginx/nginx-1.13.6=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC -Wno-deprecated-declarations -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /var/lib/gems/2.3.0/gems/passenger-5.1.8/src -I /nginx/modules/nginx_pagespeed/psol/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/chromium/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/grpc/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/protobuf/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/re2/src -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I /nginx/modules/nginx_brotli/deps/brotli/include -I src/mail -I src/stream \ -o objs/addon/src/ngx_rewrite_driver_factory.o \ /nginx/modules/nginx_pagespeed/src/ngx_rewrite_driver_factory.cc cc -c -fPIC -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/nginx/nginx-1.13.6=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC -Wno-deprecated-declarations -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /var/lib/gems/2.3.0/gems/passenger-5.1.8/src -I /nginx/modules/nginx_pagespeed/psol/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/chromium/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/grpc/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/protobuf/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/re2/src -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I /nginx/modules/nginx_brotli/deps/brotli/include -I src/mail -I src/stream \ -o objs/addon/src/ngx_rewrite_options.o \ /nginx/modules/nginx_pagespeed/src/ngx_rewrite_options.cc cc -c -fPIC -pipe -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/nginx/nginx-1.13.6=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC -Wno-deprecated-declarations -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /var/lib/gems/2.3.0/gems/passenger-5.1.8/src -I /nginx/modules/nginx_pagespeed/psol/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/chromium/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/google-sparsehash/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/grpc/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/protobuf/src/src -I /nginx/modules/nginx_pagespeed/psol/include/third_party/re2/src -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen -I /nginx/modules/nginx_pagespeed/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/src/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/apr/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/third_party/aprutil/gen/arch/linux/x64/include -I /nginx/modules/nginx_pagespeed/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I /nginx/modules/nginx_brotli/deps/brotli/include -I src/mail -I src/stream \ -o objs/addon/src/ngx_server_context.o \ /nginx/modules/nginx_pagespeed/src/ngx_server_context.cc /nginx/modules/nginx_pagespeed/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’: /nginx/modules/nginx_pagespeed/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope while (ph[i + 1].checker != ngx_http_core_try_files_phase && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ objs/Makefile:2228: recipe for target 'objs/addon/src/ngx_pagespeed.o' failed make[2]: *** [objs/addon/src/ngx_pagespeed.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/nginx/nginx-1.13.6/debian/build-nginx' Makefile:8: recipe for target 'build' failed make[1]: *** [build] Error 2 make[1]: Leaving directory '/nginx/nginx-1.13.6/debian/build-nginx' debian/rules:96: recipe for target 'build-arch.nginx' failed make: *** [build-arch.nginx] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 debian9 04:08:53 nginx-1.13.6 #

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Oct 11, 2017

@Reborns I was wondering about the commands that you executed yourself.

The build error you posted was triggered by line ngx_pagespeed.cc:3011:31.
For 1.12.34.3 that corresponds to https://github.com/pagespeed/ngx_pagespeed/blob/e6931ba03746a3a14ef43da310629090efebe907/src/ngx_pagespeed.cc#L3011.

That line does not mention ngx_http_core_try_files_phase so there's a mismatch.

The documented build instructions work fine for me with nginx-1.13.6: https://www.modpagespeed.com/doc/build_ngx_pagespeed_from_source

So In particular, I wonder how you pulled ngx_pagespeed 1.12.34.3-stable, because to it looks like you have another version.

@ghost
Copy link

@ghost ghost commented Oct 11, 2017

@oschaaf
I'm very sorry, you were right. I used a different version . With the latest version 1.12.34.3-stable everything is fine ..

@oschaaf
Copy link
Member

@oschaaf oschaaf commented Oct 11, 2017

@Reborns no problem, happy to hear it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet