New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_out_headers_and_body() return code is not checked #1465

Closed
mxwell opened this Issue Sep 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@mxwell
Copy link

mxwell commented Sep 2, 2017

Return value of the method send_out_headers_and_body(..) is not checked, even though it could return an error code:

https://github.com/pagespeed/ngx_pagespeed/blob/65761a2393cc62197129156eb7d2c9374d1aacfe/src/ngx_pagespeed.cc#L2707

I am not sure if it is a real issue, it just looks suspicious to me.

@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Sep 2, 2017

Good catch. I think that this actually was discussed earlier in a private email thread a long time ago, in the context of a h/2 related bug we were looking in to at the time. The ignores return value was assessed to unrelated at the time, and subsequently forgotten. But I think it would still make sense to properly pass through errors here. I'll take a look at that.

oschaaf added a commit that referenced this issue Sep 7, 2017

oschaaf added a commit that referenced this issue Sep 11, 2017

@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Sep 11, 2017

Fixed in #1468

@oschaaf oschaaf closed this Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment