Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
send_out_headers_and_body() return code is not checked #1465
Return value of the method
I am not sure if it is a real issue, it just looks suspicious to me.
Good catch. I think that this actually was discussed earlier in a private email thread a long time ago, in the context of a h/2 related bug we were looking in to at the time. The ignores return value was assessed to unrelated at the time, and subsequently forgotten. But I think it would still make sense to properly pass through errors here. I'll take a look at that.