New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default settings #284

Closed
jeffkaufman opened this Issue Apr 24, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Apr 24, 2013

mod_pagespeed installs a default config file, but we just give people a few lines to paste into their existing config. Occasionally there are changes in mod_pagespeed where in order to keep existing users from having mod_pagespeed change behavior out from under them a new option defaulted to "off" but was enabled in the config. There are two of these:

ModPagespeedFileCacheInodeLimit 500000
ModPagespeedAvoidRenamingIntrospectiveJavascript on

we should make these be defaults in our code.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Apr 24, 2013

For the inode limit, see the todo on system_rewrite_options.cc:105

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented May 17, 2013

Fixed by #366, released in 1.5.27.3

dinic pushed a commit to dinic/ngx_pagespeed that referenced this issue Dec 19, 2013

option defaults: defaults for inode-limit & aris
A small change, but it would be good to make it early on.
These changes should probably be mentioned in the release notes.

Set these as hardcoded defaults:

FileCacheInodeLimit 500000
AvoidRenamingIntrospectiveJavascript on

Fixes apache#284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment