Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

default settings #284

Closed
jeffkaufman opened this issue Apr 24, 2013 · 2 comments · Fixed by #363
Closed

default settings #284

jeffkaufman opened this issue Apr 24, 2013 · 2 comments · Fixed by #363

Comments

@jeffkaufman
Copy link
Contributor

mod_pagespeed installs a default config file, but we just give people a few lines to paste into their existing config. Occasionally there are changes in mod_pagespeed where in order to keep existing users from having mod_pagespeed change behavior out from under them a new option defaulted to "off" but was enabled in the config. There are two of these:

ModPagespeedFileCacheInodeLimit 500000
ModPagespeedAvoidRenamingIntrospectiveJavascript on

we should make these be defaults in our code.

@jeffkaufman
Copy link
Contributor Author

For the inode limit, see the todo on system_rewrite_options.cc:105

@jeffkaufman
Copy link
Contributor Author

Fixed by #366, released in 1.5.27.3

dinic pushed a commit to dinic/ngx_pagespeed that referenced this issue Dec 19, 2013
A small change, but it would be good to make it early on.
These changes should probably be mentioned in the release notes.

Set these as hardcoded defaults:

FileCacheInodeLimit 500000
AvoidRenamingIntrospectiveJavascript on

Fixes apache#284
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant