Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response headers like "ModPagespeed: off" not respected #356

Closed
oschaaf opened this issue May 9, 2013 · 1 comment
Closed

Response headers like "ModPagespeed: off" not respected #356

oschaaf opened this issue May 9, 2013 · 1 comment
Labels

Comments

@oschaaf
Copy link
Member

@oschaaf oschaaf commented May 9, 2013

When our upstream sends us a response header like "ModPagespeed: off", we should listen to that [1].

Currently we don't. I guess that is because we determine the request options very early.

[1] https://developers.google.com/speed/docs/mod_pagespeed/experiment

@oschaaf
Copy link
Member Author

@oschaaf oschaaf commented Aug 28, 2013

Closing, fixed in cbfbb5b via #473

@oschaaf oschaaf closed this Aug 28, 2013
morlovich pushed a commit to morlovich/ngx_pagespeed that referenced this issue Nov 25, 2013
Take the response headers into account when determining the options
for the request. Also adds tests for this.

Fixes apache#356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant