Broken reload support? #367
Comments
Testing this, Looking in to it. |
The first thing I notice is that NgxRewriteOptions::Initialize() and NgxRewriteDriverFactory::Initialize() are called during the reload in the old worker process, which probably isn't going down well. I think I need to look at some older code, and check how this was wired back then. I remember reloading used to work fine. |
The above happens when nginx.conf has disabled the use of a master process, in which case reloading isn't working at all. When configured to use a master process, reloading seems to be working most of the time - but I did manage to catch a segfault during a worker shutdown:
|
Fixed by #439 |
Remove the deferred cleanup, as in ngx_pagespeed the fetcher is owned by the RewriteDriverFactory. Fixes the backtrace pointing to net_instaweb::RewriteDriverFactory::Deleter at apache#367
In this ngx_pagespeed installation guide it notes:
I wrote to the author, who said:
The text was updated successfully, but these errors were encountered: