New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NgxServerContext's log to the vhost specific logs #447

Closed
oschaaf opened this Issue Jul 21, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@oschaaf
Copy link
Member

oschaaf commented Jul 21, 2013

When a server{} block is specified in nginx.conf, that is currently not used by messages written through NgxServerContext's message handler. These still end up in the log file configured in nginx.conf at the highest level.

It would be less confusing if we respected the vhost logging configuration, and it might also be useful in the systemtests to be able to scan the vhost specific error log for unexpected (error) messages.

@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Jul 23, 2013

Fixed in 502a604

@oschaaf oschaaf closed this Jul 23, 2013

morlovich pushed a commit to morlovich/ngx_pagespeed that referenced this issue Nov 25, 2013

logging: respect error_log in nginx.conf server blocks
This makes messages written via the NgxMessageHandler from the
NgxServerContext be written with the nginx error_log configuration
specified at the server{} level, if specified.

Fixes apache#447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment