Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong date HTTP header after HTML rewrite #577

Closed
mathieubruno opened this issue Dec 14, 2013 · 3 comments
Closed

Wrong date HTTP header after HTML rewrite #577

mathieubruno opened this issue Dec 14, 2013 · 3 comments

Comments

@mathieubruno
Copy link

@mathieubruno mathieubruno commented Dec 14, 2013

The Date HTTP Header seems to be wrong because it seems to be copied in ngx_pagespeed.cc. Shouldn't it be update with the server date (with gmtime and strftime "%a, %d %b %Y %H:%M:%S GMT" for example) ?

(Redbot.org told me the date was wrong for the pagespeed resources)

@jlporter
Copy link
Contributor

@jlporter jlporter commented Jan 14, 2014

I'm seeing a problem here too with version 1.7.30.2. The date header on the main html resource is coming back as Jan 1 1970. The header for other rewritten resources appears to be correct, it's just the rewritten HTML that is wrong.

oschaaf added a commit that referenced this issue Jan 24, 2014
When the content generated does not supply us with a date header,
invent one.

Fixes:
#604 (duplicate)
#577
oschaaf added a commit that referenced this issue Jan 24, 2014
When the content generator or origin does not supply us with a date
header, we invent one.

Fixes:
#604 (duplicate)
#577
oschaaf added a commit that referenced this issue Jan 24, 2014
When the content generator does not supply us with a date header,
we need to invent one.

Fixes:
#604 (duplicate)
#577
oschaaf added a commit that referenced this issue Jan 24, 2014
When the content generator does not supply us with a date header,
we need to create one ourselves and set it to the current date.

Fixes:
#604 (duplicate)
#577
@oschaaf
Copy link
Member

@oschaaf oschaaf commented Jan 24, 2014

@mathieubruno #605 attempts to fix this, could you try it?

@jmaessen
Copy link
Contributor

@jmaessen jmaessen commented Apr 23, 2014

It looks like this is probably closed.

@jmaessen jmaessen changed the title Date HTTP Header Wrong date HTTP header after HTML rewrite Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants