New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx Resolver API changes break the ngx_pagespeed build #578
Comments
@yaoweibin @dinic This is with the native fetcher. |
OK. We will track this issue. |
Thanks! |
Indeed, thank you for looking into this! None of the other Nginx modules I use are affected, but I can imagine there's plenty more that will get bitten by this API change. |
Building from |
Thanks for posting this, wasn't sure what was up with my build before seeing this. Appreciate it! |
This is now released with 1.7.30.2 |
Changes present in Nginx 1.5.8 break the build of the Pagespeed module (v1.7.30.1-beta).
Below is the build error I encountered while building this morning:
modules/nginx-pagespeed-module/src/ngx_fetch.cc
modules/nginx-pagespeed-module/src/ngx_fetch.cc: In member function bool net_instaweb::NgxFetch::Init():
modules/nginx-pagespeed-module/src/ngx_fetch.cc:167: error: struct ngx_resolver_ctx_s has no member named type
modules/nginx-pagespeed-module/src/ngx_fetch.cc: In static member function static void net_instaweb::NgxFetch::NgxFetchResolveDone(ngx_resolver_ctx_t_):
modules/nginx-pagespeed-module/src/ngx_fetch.cc:304: error: cannot convert ngx_addr_t to in_addr_t in assignment
make[1]: *_* [objs/addon/src/ngx_fetch.o] Error 1
make[1]: Leaving directory `/home/jprostko/nginx-1.5.8'
make: *** [build] Error 2
I discovered this forum post about the API changes, and it helps shed some light on the matter:
http://forum.nginx.org/read.php?2,245532
This is likely the commit that is causing the issue, I believe, although other ones made around the same time could be related, I suppose:
http://mailman.nginx.org/pipermail/nginx-devel/2013-December/004682.html
The text was updated successfully, but these errors were encountered: