/incubator-pagespeed-ngx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownstreamCachePurgeLocationPrefix removes cache headers for .pagespeed. resources #652

Closed
oschaaf opened this Issue Apr 1, 2014 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@oschaaf
@oschaaf
Copy link
Member

oschaaf commented Apr 1, 2014

As reported at ngx-pagespeed-discuss:
Adding this line to nginx.conf makes the cache headers disappear for .pagespeed. resources:

pagespeed DownstreamCachePurgeLocationPrefix http://localhost:80/;

According to @anupamadutta:

"Regarding Expires header, I am wondering if https://github.com/pagespeed/ngx_pagespeed/pull/555/files could have anything to do with this. This was intended to be applied for HTML only, but I don't know if it happened to somehow get rid of Expires (and other headers) for other resources as well. Could you take a look?"

oschaaf added a commit that referenced this issue Apr 1, 2014

@oschaaf
downstream-caching: Fix pagespeed resource response headers 
- Make kPreserveOnlyCacheControl do what it says on the tin
- Serve pagespeed resources with the response headers computed
  by PSOL regardless of whether downstream caching is configured.

Fixes #652
efbf317

oschaaf added a commit that referenced this issue Apr 2, 2014

@oschaaf
downstream-caching: Fix pagespeed resource response headers 
- Make kPreserveOnlyCacheControl do what it says on the tin
- Serve pagespeed resources with the response headers computed
  by PSOL regardless of whether downstream caching is configured.

Fixes #652
578ef01

@oschaaf oschaaf referenced this issue Apr 2, 2014

Merged

downstream-caching: Fix pagespeed resource response headers #653

oschaaf added a commit that referenced this issue Apr 10, 2014

@oschaaf
downstream-caching: Fix pagespeed resource response headers 
- Make kPreserveOnlyCacheControl do what it says on the tin
- Serve pagespeed resources with the response headers computed
  by PSOL regardless of whether downstream caching is configured.

Fixes #652
76114de

oschaaf added a commit that referenced this issue Apr 10, 2014

@oschaaf
downstream-caching: Fix pagespeed resource response headers 
- Make kPreserveOnlyCacheControl do what it says on the tin
- Serve pagespeed resources with the response headers computed
  by PSOL regardless of whether downstream caching is configured.

Fixes #652
72f3c79
@oschaaf

This comment has been minimized.

Sign in to view
Copy link
Member

oschaaf commented Apr 10, 2014

Confirmed fixed per email
Merged via #653
Closing

@oschaaf oschaaf closed this Apr 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment