New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticAssetPrefix not working #705

Closed
nikolay opened this Issue May 19, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@nikolay
Copy link
Contributor

nikolay commented May 19, 2014

The documentation here https://developers.google.com/speed/pagespeed/module/configuration says that StaticAssetPrefix is now available and that the default path has changed to /pagespeed_static, but PageSpeed is giving an error that StaticAssetPrefix is not recognized and also the Nginx configuration still tells people to configure using /ngx_pagespeed_static as location.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented May 19, 2014

Could you paste the error you're getting with 1.8?

@nikolay

This comment has been minimized.

Copy link
Contributor

nikolay commented May 19, 2014

@jeffkaufman Some of the custom paths didn't work in the server block, so, I moved to the http, but my setting of pagespeed StaticAssetPrefix "/static/"; is still giving me: 2014/05/19 19:32:54 [emerg] 5484#0: "pagespeed" directive "StaticAssetPrefix" not recognized or too many arguments in /etc/nginx/nginx.conf:29.

@nikolay

This comment has been minimized.

Copy link
Contributor

nikolay commented May 20, 2014

@jeffkaufman So, even if I decide not use this feature as it's not been implemented in 1.8, which path should I use in the location - /pagespeed_static or the old /ngx_pagespeed_static? You understand that there are two issues here, not just one.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented May 20, 2014

You're right, there's a big problem with StaticAssetPrefix in ngx_pagespeed. The option isn't going to be settable at all until we fix it, which means that the prefix will be /pagespeed_static/ and can't be configured.

I should be able to get a pull request out to fix this today, and we'll include it in the point release we're putting together.

@jeffkaufman jeffkaufman changed the title StaticAssetPrefix Not Working; Misleading and Conflicting Documentation StaticAssetPrefix not working May 20, 2014

@nikolay

This comment has been minimized.

Copy link
Contributor

nikolay commented May 20, 2014

@jeffkaufman Thanks.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented May 27, 2014

This will be in 1.8.32.3

jeffkaufman added a commit that referenced this issue May 27, 2014

options: support StaticAssetPrefix
Backporting this to master for 1.8.31.3.

Fixes #705.
@nikolay

This comment has been minimized.

Copy link
Contributor

nikolay commented May 27, 2014

@jeffkaufman Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment