This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
messages: unbreak /ngx_pagespeed_messages #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shared circular buffer wasn't hooked up fully, which meant loading /ngx_pagespeed_messages didn't work. This fixes that and adds a test. I also noticed while adding this that the 'Handling of large files' test wasn't set up properly, so I converted that to use start_test. Fixing that exposed another bug where the 'Handling of large files' test was actually failing but being marked as an expected failure by being grouped in with the test above. Adding `pagespeed MaxHtmlParseBytes 5000` to the appropriate location made it test what it was supposed to be testing again, and the underlying feature wasn't broken.
|
LGTM |
jeffkaufman
added a commit
that referenced
this pull request
Nov 12, 2013
messages: unbreak /ngx_pagespeed_messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared circular buffer wasn't hooked up fully, which meant loading
/ngx_pagespeed_messagesdidn't work. This fixes that and adds a test.I also noticed while adding this that the 'Handling of large files' test wasn't set up properly, so I converted that to use start_test.
Fixing that exposed another bug where the 'Handling of large files' test was actually failing but being marked as an expected failure by being grouped in with the test above. Adding
pagespeed MaxHtmlParseBytes 5000to the appropriate location made it test what it was supposed to be testing again, and the underlying feature wasn't broken.Fixes #559