New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: unbreak /ngx_pagespeed_messages #560

Merged
merged 1 commit into from Nov 12, 2013

Conversation

Projects
None yet
2 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Nov 12, 2013

The shared circular buffer wasn't hooked up fully, which meant loading /ngx_pagespeed_messages didn't work. This fixes that and adds a test.

I also noticed while adding this that the 'Handling of large files' test wasn't set up properly, so I converted that to use start_test.

Fixing that exposed another bug where the 'Handling of large files' test was actually failing but being marked as an expected failure by being grouped in with the test above. Adding pagespeed MaxHtmlParseBytes 5000 to the appropriate location made it test what it was supposed to be testing again, and the underlying feature wasn't broken.

Fixes #559

messages: unbreak /ngx_pagespeed_messages
The shared circular buffer wasn't hooked up fully, which meant loading
/ngx_pagespeed_messages didn't work.  This fixes that and adds a test.

I also noticed while adding this that the 'Handling of large files' test
wasn't set up properly, so I converted that to use start_test.

Fixing that exposed another bug where the 'Handling of large files' test
was actually failing but being marked as an expected failure by being
grouped in with the test above.  Adding `pagespeed MaxHtmlParseBytes 5000`
to the appropriate location made it test what it was supposed to be testing
again, and the underlying feature wasn't broken.
@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Nov 12, 2013

LGTM

jeffkaufman added a commit that referenced this pull request Nov 12, 2013

Merge pull request #560 from pagespeed/jefftk-fix-messages
messages: unbreak /ngx_pagespeed_messages

@jeffkaufman jeffkaufman merged commit fa5815e into master Nov 12, 2013

@jeffkaufman jeffkaufman deleted the jefftk-fix-messages branch Nov 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment