This repository was archived by the owner on Apr 10, 2025. It is now read-only.
Allow admin paths to be set at server scope.#701
Merged
jeffkaufman merged 1 commit intotrunk-trackingfrom May 12, 2014
Merged
Conversation
Contributor
Author
|
This should be backported to |
Contributor
|
LGTM |
jeffkaufman
added a commit
that referenced
this pull request
May 12, 2014
…-scope
move settings to server scope
Allow you to set `MessagesPath`, `StatisticsPath`, `AdminPath`, or `ConsolePath` in a `server {}` block.
Contributor
Author
|
Backported to |
Contributor
|
Thanks for this! It was a bit messy to have this in the |
Contributor
|
@jeffkaufman Do we need to be adding in order to enable the admins? |
Contributor
Author
|
If you turn on any of these paths with |
Contributor
|
Okay, I didn't know they are disabled by default. It seems that |
Contributor
Author
|
With 1.8 they are now disabled by default; they didn't used to be. We don't want to be opening up these paths if people forget to put in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow you to set
MessagesPath,StatisticsPath,AdminPath, orConsolePathin aserver {}block.