Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Allow admin paths to be set at server scope. #701

Merged
merged 1 commit into from
May 12, 2014

Conversation

jeffkaufman
Copy link
Contributor

Allow you to set MessagesPath, StatisticsPath, AdminPath, or ConsolePath in a server {} block.

@jeffkaufman
Copy link
Contributor Author

This should be backported to master once ready.

@jmarantz
Copy link
Contributor

LGTM

jeffkaufman added a commit that referenced this pull request May 12, 2014
…-scope

move settings to server scope

Allow you to set `MessagesPath`, `StatisticsPath`, `AdminPath`, or `ConsolePath`  in a `server {}` block.
@jeffkaufman jeffkaufman merged commit a7fdc86 into trunk-tracking May 12, 2014
@jeffkaufman jeffkaufman deleted the jefftk-move-settings-to-server-scope branch May 12, 2014 13:34
@jeffkaufman
Copy link
Contributor Author

Backported to master as 90e4c40.

@nikolay
Copy link
Contributor

nikolay commented May 22, 2014

Thanks for this! It was a bit messy to have this in the http {}!

@nikolay
Copy link
Contributor

nikolay commented May 22, 2014

@jeffkaufman Do we need to be adding in order to enable the admins?

location /pagespeed_admin { allow 127.0.0.1; deny all; }
location /pagespeed_global_admin { allow 127.0.0.1; deny all; }

@jeffkaufman
Copy link
Contributor Author

If you turn on any of these paths with pagespeed SomePath ... then it will be open to anyone. The suggested location blocks are for restricting the handler to some IP that you know only admins will have access to.

@nikolay
Copy link
Contributor

nikolay commented May 22, 2014

Okay, I didn't know they are disabled by default. It seems that pagespeed SomePath ...; is only for changing the default location.

@jeffkaufman
Copy link
Contributor Author

With 1.8 they are now disabled by default; they didn't used to be. We don't want to be opening up these paths if people forget to put in the location ... { deny ... }.

@jmaessen jmaessen changed the title move settings to server scope Allow admin paths to be set at server scope. May 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants