Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

options: support setting NumRewriteThreads - #731

Merged
jeffkaufman merged 2 commits into
trunk-trackingfrom
jefftk-thread-config
Jun 18, 2014
Merged

jeffkaufman merged 2 commits into
trunk-trackingfrom
jefftk-thread-config

Conversation

@jeffkaufman

Copy link
Copy Markdown
Contributor

Support setting NumRewriteThreads and NumExpensiveRewriteThreads.

This means moving a bunch of thread-related code from apache/ to system/. While we're at it, also move handling of use_per_vhost_statistics, install_crash_handler, and rate_limit_background_fetches to system/ so they're no longer duplicated between nginx and apache.

I also partly cleaned up the way we handle options that are set on the factory, getting the duplication out of apache/ and nginx/ and moving the code into system/.

Fixes #728

Several rewrite driver factory options are duplicated between apache and nginx.  Instead of duplicating this one too, a PSOL change moves them into system/, and this change takes advantage of that move.
@oschaaf

oschaaf commented Jun 17, 2014

Copy link
Copy Markdown
Member

Great, LGTM!

jeffkaufman added a commit that referenced this pull request Jun 18, 2014
options: support setting NumRewriteThreads
@jeffkaufman
jeffkaufman merged commit 10f5093 into trunk-tracking Jun 18, 2014
@jeffkaufman
jeffkaufman deleted the jefftk-thread-config branch June 18, 2014 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants