New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: support setting NumRewriteThreads #731

Merged
merged 2 commits into from Jun 18, 2014

Conversation

Projects
None yet
2 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Jun 16, 2014

Support setting NumRewriteThreads and NumExpensiveRewriteThreads.

This means moving a bunch of thread-related code from apache/ to system/. While we're at it, also move handling of use_per_vhost_statistics, install_crash_handler, and rate_limit_background_fetches to system/ so they're no longer duplicated between nginx and apache.

I also partly cleaned up the way we handle options that are set on the factory, getting the duplication out of apache/ and nginx/ and moving the code into system/.

Fixes #728

Support setting NumRewriteThreads and NumExpensiveRewriteThreads
Several rewrite driver factory options are duplicated between apache and nginx.  Instead of duplicating this one too, a PSOL change moves them into system/, and this change takes advantage of that move.
@oschaaf

This comment has been minimized.

Copy link
Member

oschaaf commented Jun 17, 2014

Great, LGTM!

jeffkaufman added a commit that referenced this pull request Jun 18, 2014

Merge pull request #731 from pagespeed/jefftk-thread-config
options: support setting NumRewriteThreads

@jeffkaufman jeffkaufman merged commit 10f5093 into trunk-tracking Jun 18, 2014

@jeffkaufman jeffkaufman deleted the jefftk-thread-config branch Jun 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment