Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upoptions: support setting NumRewriteThreads #731
Conversation
This comment has been minimized.
This comment has been minimized.
|
Great, LGTM! |
added a commit
that referenced
this pull request
Jun 18, 2014
jeffkaufman
merged commit 10f5093
into
trunk-tracking
Jun 18, 2014
jeffkaufman
deleted the
jefftk-thread-config
branch
Jun 18, 2014
jeffkaufman
referenced this pull request
Jun 18, 2014
Closed
Support `NumRewriteThreads` and `NumExpensiveRewriteThreads` #728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jeffkaufman commentedJun 16, 2014
Support setting NumRewriteThreads and NumExpensiveRewriteThreads.
This means moving a bunch of thread-related code from apache/ to system/. While we're at it, also move handling of use_per_vhost_statistics, install_crash_handler, and rate_limit_background_fetches to system/ so they're no longer duplicated between nginx and apache.
I also partly cleaned up the way we handle options that are set on the factory, getting the duplication out of apache/ and nginx/ and moving the code into system/.
Fixes #728