This repository was archived by the owner on Apr 10, 2025. It is now read-only.
options: support setting NumRewriteThreads #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several rewrite driver factory options are duplicated between apache and nginx. Instead of duplicating this one too, a PSOL change moves them into system/, and this change takes advantage of that move.
|
Great, LGTM! |
jeffkaufman
added a commit
that referenced
this pull request
Jun 18, 2014
options: support setting NumRewriteThreads
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting NumRewriteThreads and NumExpensiveRewriteThreads.
This means moving a bunch of thread-related code from apache/ to system/. While we're at it, also move handling of use_per_vhost_statistics, install_crash_handler, and rate_limit_background_fetches to system/ so they're no longer duplicated between nginx and apache.
I also partly cleaned up the way we handle options that are set on the factory, getting the duplication out of apache/ and nginx/ and moving the code into system/.
Fixes #728