Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown Properties from config file when parsing #2336

Merged
merged 1 commit into from Aug 8, 2018

Conversation

srkukarni
Copy link
Contributor

Motivation

As Functions evolve, we will be adding new properties/fields to the FunctionConfig. There will be fields present in the config files that won't make sense for previous admin tool installation. This especially happens when submitting pulsar functions using newer client to run over kubernetes with an older installation of pulsar. This pr will mark the unknown fields to be ignored to get over that problem

Modifications

Describe the modifications you've done.

Result

After your change, what will change.

@srkukarni
Copy link
Contributor Author

run cpp tests

@srkukarni
Copy link
Contributor Author

run integration tests

@sijie sijie added this to the 2.2.0-incubating milestone Aug 8, 2018
@sijie sijie merged commit 376bc8b into apache:master Aug 8, 2018
@srkukarni srkukarni deleted the ignore_unknown branch August 8, 2018 05:02
sijie pushed a commit that referenced this pull request Aug 27, 2018
### Motivation
As Functions evolve, we will be adding new properties/fields to the FunctionConfig. There will be fields present in the config files that won't make sense for previous admin tool installation. This especially happens when submitting pulsar functions using newer client to run over kubernetes with an older installation of pulsar. This pr will mark the unknown fields to be ignored to get over that problem
@sijie
Copy link
Member

sijie commented Aug 27, 2018

cherry-picked
5ac1322 in branch-2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants