RATIS-473. Clarify size and length methods on LogStream #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getLength() was meant to be the number of records in a log but was implemented as the size in bytes of the records in the log. This commit adds a getSize() which takes the old implementation of getLength(), and then reimplements getLength() as the number of records in the log.
|
One more, @VladRodionov and @chrajeshbabu |
|
It's looking good @joshelser . |
ratis-logservice/src/main/java/org/apache/ratis/logservice/server/LogStateMachine.java
Show resolved
Hide resolved
|
You probably have some minor issue (see my comment inline in files changed), otherwise is looking good, @joshelser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLength() was meant to be the number of records in a log
but was implemented as the size in bytes of the records in
the log. This commit adds a getSize() which takes the old
implementation of getLength(), and then reimplements
getLength() as the number of records in the log.