New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATIS-473. Clarify size and length methods on LogStream #9

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@joshelser
Copy link
Member

joshelser commented Jan 9, 2019

getLength() was meant to be the number of records in a log
but was implemented as the size in bytes of the records in
the log. This commit adds a getSize() which takes the old
implementation of getLength(), and then reimplements
getLength() as the number of records in the log.

RATIS-473. Clarify size and length methods on LogStream
getLength() was meant to be the number of records in a log
but was implemented as the size in bytes of the records in
the log. This commit adds a getSize() which takes the old
implementation of getLength(), and then reimplements
getLength() as the number of records in the log.
@joshelser

This comment has been minimized.

Copy link
Member

joshelser commented Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment