Skip to content
This repository has been archived by the owner. It is now read-only.

[IOTA-21] #5

Merged
merged 6 commits into from Jul 5, 2016

Conversation

Projects
None yet
3 participants
@phalodi
Copy link
Contributor

commented Jul 4, 2016

Refactor the built to manage dependencies in more efficient way and add scalastyle plugin for code quality.

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

@barbaragomes can you once review it and give comment on PR

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

@phalodi phalodi changed the title Iota 21 [IOTA-21] Jul 4, 2016

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2016

Thanks @phalodi.

We will review it.

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2016

Taking a quick look I found one issue:

  1. val ZMQDependecies = provided(akka_actor, zmq, fey) the zmq dependency should not be provided
@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

@barbaragomes thanks for the comment its should be compile time right?

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2016

@phalodi Yup.

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

@barbaragomes i fix it and push you can review it.

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2016

@phalodi My apologies, but I'm not sure if it should be runtime. The compile configuration will make the dependency also available in runtime?

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

@barbaragomes yess compile dependency will available at runtime and test in both.

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2016

@phalodi PR has been tested and will be merged once you, please, submit the following modifications:

  1. BuildSettings: change organization := "com.libit" to organization := "org.apache.iota"
  2. Remove all reference to the fey project since this folder is not actually a SBT project, like for example lazy val fey = Project( and aggregate = Seq(Stream, ZMQ,fey)
  3. PerformersBuild: Remove stream and zmq from mainClass := Some

I understand that some of the requested changes were part of the first SBT Build.scala but it would be nice if we could have all of them in the same PR since we are refactoring it =)

Thanks

*Change organization name in build settings.
*Remove fey project from build.
*Remove main class from ZMQ and Stream.
@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2016

@barbaragomes I make changes and push it once review it and give comment if needed.

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2016

@phalodi Can you please change the organization name for all of the sub-projects?

And also remove the building settings for for fey: lazy val FeybuildSettings

@phalodi

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2016

@barbaragomes I remove fey setting from build settings and also add organization name to basic setting so every project have it.

@barbaragomes

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2016

@phalodi Thank you! We will be merging it soon.

@asfgit asfgit merged commit c3f55e7 into apache:master Jul 5, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.