[ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, added code comments and did a cleanup. JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13
…ionGroup.json's path
|
It looks good, please @vongosling @lollipopjin review it. |
|
IMO, we can postpone merge this PR here, thanks @Zhang-Ke |
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
（1）在AbstractSendMessageProcessor抽象类中已经定义sendMessageHookList变量， 则无需再在实现类中去定义该变量 （2）在SendMessageProcessor中需要对consumerSendMsgBack进行处理，应调用ConsumeMessageHook#consumeMessageAfter记录轨迹以及计费数据，因此SendMessageProcessor中需注册registerConsumeMessageHook； （3）AbstractSendMessageProcessor的executeSendMessageHookBefore方法中获取requestHeader 未考虑多个版本的协议
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lyx2000
pushed a commit
to lyx2000/rocketmq
that referenced
this pull request
Jun 30, 2023
Signed-off-by: SSpirits <admin@lv5.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path
JIRRA ISSUE: https://issues.apache.org/jira/browse/ROCKETMQ-16