-
Notifications
You must be signed in to change notification settings - Fork 8.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
optimize: check relation of before status and after status when updat…
…ing global session (#4629)
- Loading branch information
Showing
7 changed files
with
148 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
server/src/main/java/io/seata/server/session/SessionStatusValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Copyright 1999-2019 Seata.io Group. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.seata.server.session; | ||
|
|
||
| import io.seata.core.model.GlobalStatus; | ||
|
|
||
| /** | ||
| * The type change status validator. | ||
| * | ||
| * @author Bughue | ||
| */ | ||
| public class SessionStatusValidator { | ||
|
|
||
| /** | ||
| * is timeout global status | ||
| * | ||
| * @param status the global session | ||
| */ | ||
| public static boolean isTimeoutGlobalStatus(GlobalStatus status) { | ||
| return status == GlobalStatus.TimeoutRollbacked | ||
| || status == GlobalStatus.TimeoutRollbackFailed | ||
| || status == GlobalStatus.TimeoutRollbacking | ||
| || status == GlobalStatus.TimeoutRollbackRetrying; | ||
| } | ||
|
|
||
| /** | ||
| * is rollback global status | ||
| * | ||
| * @param status the global session | ||
| */ | ||
| public static boolean isRollbackGlobalStatus(GlobalStatus status) { | ||
| return status == GlobalStatus.Rollbacking | ||
| || status == GlobalStatus.RollbackRetrying | ||
| || status == GlobalStatus.Rollbacked | ||
| || status == GlobalStatus.RollbackFailed | ||
| || status == GlobalStatus.RollbackRetryTimeout; | ||
| } | ||
|
|
||
| /** | ||
| * is commit global status | ||
| * | ||
| * @param status the global session | ||
| */ | ||
| public static boolean isCommitGlobalStatus(GlobalStatus status) { | ||
| return status == GlobalStatus.Committing | ||
| || status == GlobalStatus.AsyncCommitting | ||
| || status == GlobalStatus.CommitRetrying | ||
| || status == GlobalStatus.Committed | ||
| || status == GlobalStatus.CommitFailed | ||
| || status == GlobalStatus.CommitRetryTimeout; | ||
| } | ||
|
|
||
| /** | ||
| * check the relation of before status and after status | ||
| * | ||
| * @param before the global session | ||
| * @param after the global session | ||
| */ | ||
| public static boolean validateUpdateStatus(GlobalStatus before, GlobalStatus after) { | ||
| if (isTimeoutGlobalStatus(before) && isCommitGlobalStatus(after)) { | ||
| return false; | ||
| } | ||
| if (isCommitGlobalStatus(before) && isTimeoutGlobalStatus(after)) { | ||
| return false; | ||
| } | ||
| if (isRollbackGlobalStatus(before) && isCommitGlobalStatus(after)) { | ||
| return false; | ||
| } | ||
| if (isCommitGlobalStatus(before) && isRollbackGlobalStatus(after)) { | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
server/src/test/java/io/seata/server/session/SessionStatusValidatorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright 1999-2019 Seata.io Group. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.seata.server.session; | ||
|
|
||
| import io.seata.core.model.GlobalStatus; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
|
|
||
| /** | ||
| * the type change status validator test | ||
| * | ||
| * @author Bughue | ||
| */ | ||
| @SpringBootTest | ||
| public class SessionStatusValidatorTest { | ||
|
|
||
| @Test | ||
| public void testValidateUpdateStatus(){ | ||
| Assertions.assertEquals(true, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Begin, GlobalStatus.Committing)); | ||
| Assertions.assertEquals(true, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Committing, GlobalStatus.Committed)); | ||
|
|
||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Committing, GlobalStatus.TimeoutRollbacking)); | ||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.TimeoutRollbacking, GlobalStatus.Committing)); | ||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Committing, GlobalStatus.Rollbacking)); | ||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Rollbacking, GlobalStatus.Committing)); | ||
|
|
||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Committed, GlobalStatus.Rollbacked)); | ||
| Assertions.assertEquals(false, SessionStatusValidator.validateUpdateStatus(GlobalStatus.Committed, GlobalStatus.TimeoutRollbacking)); | ||
|
|
||
| } | ||
| } |