[Feature][Connector][Elasticsearch] Support https protocol #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
support-elasticsearch-https
branch
from
4ef09d6
to
302b80a
Compare
|
PTAL |
CalvinKirs
reviewed
Jan 30, 2023
Comment on lines
39
to
40
| public final class DerUtils { | ||
| public static final int SEQUENCE_TAG = 0x30; |
There was a problem hiding this comment.
This class looks to be from the airlift project, please confirm.
hailin0
force-pushed
the
support-elasticsearch-https
branch
from
302b80a
to
eb11ac5
Compare
hailin0
commented
Jan 30, 2023
| } | ||
|
|
||
| public BulkResponse bulk(String requestBody) { | ||
| Request request = new Request("POST", "_bulk"); | ||
| Request request = new Request("POST", "/_bulk"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
compatible with aws opensearch
hailin0
force-pushed
the
support-elasticsearch-https
branch
2 times, most recently
from
5ba48da
to
23df106
Compare
EricJoy2048
reviewed
Jan 31, 2023
* support https protocol * compatible with opensearch
hailin0
force-pushed
the
support-elasticsearch-https
branch
from
23df106
to
3f19ec1
Compare
fixed @EricJoy2048 |
CalvinKirs
approved these changes
Jan 31, 2023
TyrantLucifer
approved these changes
Feb 1, 2023
|
@hailin0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.