Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all protocol implementations testable on the command line #1097

Closed
jnioche opened this issue Sep 28, 2023 · 0 comments
Closed

Make all protocol implementations testable on the command line #1097

jnioche opened this issue Sep 28, 2023 · 0 comments
Labels
core enhancement
Milestone
2.10

Comments

@jnioche
Copy link
Contributor

jnioche commented Sep 28, 2023

All the implementations extending AbstractHTTPProtocol can be easily tested on the command line as explained in this discussion

storm local target/opencrawl-1.0-SNAPSHOT.jar com.digitalpebble.stormcrawler.protocol.selenium.RemoteDriverProtocol -f crawler-conf.yaml https://storm.apache.org/

There is no reason why the same functionality couldn't be extended to other protocol implementations such as FileProtocol or the DelegatorProtocol. This can be done by simply moving the logic from AbstractHTTPProtocol to the Protocol interface.
@jnioche jnioche added this to the 2.10 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
2.10
Development

No branches or pull requests
1 participant
@jnioche