Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md is missing mysql_config command being a developer dependency #7399

Open
rjurney opened this issue Apr 28, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@rjurney
Copy link
Contributor

commented Apr 28, 2019

requirements-dev.txt requires mysqlclient which requires the OS dependency the mysql_config command. CONTRIBUTING.md does not let the new developer know this.

Expected results

pip install -r requirements-dev.txt

Expect: success!

Actual results

mysql_config not found!

How to reproduce the bug

  1. Have a system without the mysql_config command on it
  2. Run: pip install -r requirements-dev.txt
  3. See error

Environment

  • OS: Ubuntu 18.04 and OS X 10.14.4
  • superset version: [release--0.31, b3aa5633]
  • python version: 3.6.7, 3.6.8, 3.7.3

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • [*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [*] I have reproduced the issue with at least the latest released version of superset.
  • [*] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@issue-label-bot

This comment has been minimized.

Copy link

commented Apr 28, 2019

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.72. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the #bug label Apr 28, 2019

@rjurney rjurney referenced this issue Apr 28, 2019

Closed

Updating contributing/install docs #7386

1 of 12 tasks complete
@mistercrunch

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

I found that pip install mysqlclient installs a newer version that works. I think we just need to bump the version in requirements-dev.txt

$ pip freeze | grep -i mysql
mysqlclient==1.4.2.post1
@rjurney

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

@mistercrunch Updated so in master pull #7426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.