Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up db_engine_specs and add type hints #7412

Open
khtruong opened this issue Apr 30, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@khtruong
Copy link
Contributor

commented Apr 30, 2019

Is your feature request related to a problem? Please describe.
db_engine_specs has gotten large and should be broken up in multiple files. The class is also not completely typed.

Describe the solution you'd like
There should be a file for each engine spec and the file should be typed.

@issue-label-bot

This comment has been minimized.

Copy link

commented Apr 30, 2019

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@khtruong khtruong referenced this issue Apr 30, 2019

Merged

feat: see Presto row and array data types #7391

1 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.