Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e.map is not a function explore view #8961

Open
micimize opened this issue Jan 14, 2020 · 2 comments
Open

e.map is not a function explore view #8961

micimize opened this issue Jan 14, 2020 · 2 comments
Labels

Comments

@micimize
Copy link

@micimize micimize commented Jan 14, 2020

I encountered #2687 while casting from a table visualization with specified columns to a bar chart time series. Refreshing the page gets rid of the issue

Expected results

Moving between viz modes does not crash the slice explorer

Actual results

I reproduced #2687 by attempting to switch from a table viz to a time-series bar chart viz after creating the chart via the explore button in sql lab, and debugged on the exception to see:
image

How to reproduce the bug

while debugging on all exceptions

  1. create a table viz with specified columns and no metrics
  2. attempt to switch the viz type to line or time series bar chart
  3. Error should be thrown. You should see that e in the console is the above structure

Environment

(please complete the following information):

  • superset version: I'm on a slightly modified fork of 0.34.0. Others in the comments of #2687 corroborate. Would be surprised if it had been fixed
@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Jan 14, 2020

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the #bug label Jan 14, 2020
@micimize

This comment has been minimized.

Copy link
Author

@micimize micimize commented Jan 14, 2020

The TimeTable expects the logged structure here:

const { records, columns } = queryData.data;

But superset-ui-legacy-preset-chart-nvd3/src/transformProps.js (and thus the line plugin, etc) expects an array:

  const rawData = queryData.data || [];
  const data = Array.isArray(rawData)
    ? rawData.map(row => ({
        ...row,
        key: formatLabel(row.key, datasource.verboseMap),
      }))
    : rawData;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.