Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja url_param in Sql_lab sql query not working #8962

Open
labelhero opened this issue Jan 14, 2020 · 3 comments
Open

jinja url_param in Sql_lab sql query not working #8962

labelhero opened this issue Jan 14, 2020 · 3 comments
Labels

Comments

@labelhero
Copy link

@labelhero labelhero commented Jan 14, 2020

Unable to run query after passing url_param parameters to sql_lab query. Button does not do anything.

image

This functionality used to run in 0.28 version, however after upgrading to 0.35 it not running anymore.

Are these fields supposed to be pre-filled using url_param?

image

Can some one please help with this, if possible please post some examples on how to pass url_param in newer version.

A clear and concise description of what the bug is.

Expected results

what you expected to happen.

Actual results

what actually happens.

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

  1. Pass the table parameters in the url and sql query with url_param
  2. All database,schema and table fields are supposed to be empty.
  3. Click "Run query" button.
  4. Nothing happens.

Environment

(please complete the following information):

  • superset version: 0.35.1
  • python version: 3.6
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Jan 14, 2020

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the #bug label Jan 14, 2020
@villebro

This comment has been minimized.

Copy link
Contributor

@villebro villebro commented Jan 14, 2020

There was a fix related to url_params that was included in 0.35.1, see #8536 . However, that particular PR focused on all other areas of Superset except SqlLab. I can look into this in the coming days.

@villebro

This comment has been minimized.

Copy link
Contributor

@villebro villebro commented Jan 15, 2020

This does appear to be a regression, not sure when it was introduced. I need to think about how to resolve this, as there are many potential solutions. Also, the url_params feature needs to be more thoroughly unit tested and documented going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.