Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing VictoryTheme.js #10445

Merged
merged 1 commit into from Jul 28, 2020
Merged

chore: removing VictoryTheme.js #10445

merged 1 commit into from Jul 28, 2020

Conversation

rusackas
Copy link
Member

SUMMARY

I've killed off this unused file before in #9063, but it's proved resilient somehow. Not sure what transpired there, but here we go again!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from etr2460 July 28, 2020 00:13
etr2460
etr2460 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird... this was the commit that actually got merged from the previous PR: 8c16ff0

0 lines added and removed

@mistercrunch
Copy link
Member

dead

@rusackas rusackas merged commit 98437fb into apache:master Jul 28, 2020
@rusackas rusackas deleted the chore-removing-victoryTheme branch July 28, 2020 04:12
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@rusackas @auxten
chore: removing VictoryTheme.js (apache#10445)
35834ac
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rusackas @mistercrunch @etr2460