Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct lint errors #10918

Merged
merged 1 commit into from Sep 16, 2020
Merged

fix: correct lint errors #10918

merged 1 commit into from Sep 16, 2020

Conversation

eschutho
Copy link
Member

SUMMARY

Fixes current linting errors from rules that were recently turned on.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

linting should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai
Copy link
Member

nytai commented Sep 16, 2020

Ah, looks like you got to them before me #10919

@nytai nytai merged commit a3519b4 into apache:master Sep 16, 2020
@nytai nytai deleted the elizabeth/fix-lint branch September 16, 2020 20:42
@nytai nytai mentioned this pull request Sep 16, 2020
6 tasks
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants