Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set up client-side redirects from previous era docs urls #10921

Merged
merged 9 commits into from Sep 18, 2020

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Sep 16, 2020

SUMMARY

Routes for old docs take people to dead pages. This ensures that they're taken to the page most closely matching the original page.

See route mapping doc: https://docs.google.com/document/d/1Yv4f2n_1lL5GHaQkpvG1imCHS7XVKJmyIqoudXvFygc/edit

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

docs/gatsby-node.js Outdated Show resolved Hide resolved
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # actually makes this into giant header text when viewing the readme on github. The [//]: # doesn't work as expected either. If you want to sink a little time into figuring out how to make this a proper markdown comment block, that'd be appreciated. Both of the aforementioned treatments don't work as intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! I did this via the Github merge conflict UI, hmm I'l fix locally!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's the <!-- syntax now... that was causing other errors for me (couldn't run the build script), but maybe you'll have better luck?

@pkdotson
Copy link
Member

LGTG once you fix CI stuff.

@mistercrunch
Copy link
Member

mistercrunch commented Sep 17, 2020

https://chris.beams.io/posts/git-commit/
PR titles become commit messages in master in our "Squash and Merge" setting

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch changed the title Redirects docs: set up client-side redirects from previous era docs urls Sep 18, 2020
@rusackas rusackas merged commit 4a4fdb1 into apache:master Sep 18, 2020
@rusackas rusackas deleted the redirects branch September 18, 2020 20:31
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…e#10921)

* one simple redirect, as a test

* adding license to header

* painstakingly added SEO redirects!

* addressed feedback and ran lint-fix!

* lets try newline again!

* Revert "lets try newline again!"

This reverts commit 20f89bd.

* Revert "Revert "lets try newline again!""

This reverts commit e441edc.

* wait... there were TWO newlines?

Co-authored-by: Evan Rusackas <evan@preset.io>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants