New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code refactoring #2139

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
2 participants
@asdf2014
Member

asdf2014 commented Feb 8, 2017

Some code refactoring

@mistercrunch

This comment has been minimized.

Contributor

mistercrunch commented Feb 8, 2017

LGTM, thanks for fixing the typos and all

@mistercrunch mistercrunch merged commit 1f58e18 into apache:master Feb 8, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.003%) to 80.557%
Details
code-quality/landscape Code quality increased by 0.09%
Details
codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 9, 2017

It's my pleasure :D

@asdf2014 asdf2014 deleted the asdf2014:code_refactor branch Feb 9, 2017

robert-digit added a commit to robert-digit/superset that referenced this pull request Feb 13, 2017

rlei added a commit to rlei/superset that referenced this pull request Feb 24, 2017

SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017

SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment