Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] ElasticSearch connector integration #2953

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@mistercrunch
Copy link
Contributor

mistercrunch commented Jun 12, 2017

Getting started on adding support for ElasticSearch

@mistercrunch mistercrunch changed the title [WiP] elastic search integration [WiP] ElasticSearch connector integration Jun 12, 2017

@davidecavestro

This comment has been minimized.

Copy link

davidecavestro commented Jun 17, 2017

@mistercrunch please let me know if I can contribute someway

@mistercrunch

This comment has been minimized.

Copy link
Contributor Author

mistercrunch commented Jun 17, 2017

I'm going to try and find some time to move forward over the weekend. This may be hard to break into subtasks....

@davidecavestro

This comment has been minimized.

Copy link

davidecavestro commented Jun 17, 2017

Great

@Zuckonit

This comment has been minimized.

Copy link

Zuckonit commented Jul 13, 2017

sorry, but any update about this feature?

@mistercrunch mistercrunch force-pushed the mistercrunch:elastic branch from 83874d4 to 4aae9fe Jul 26, 2017

@teamsoo

This comment has been minimized.

Copy link

teamsoo commented Aug 8, 2017

@mistercrunch Hi, any update about this super cool feature?

@mistercrunch

This comment has been minimized.

Copy link
Contributor Author

mistercrunch commented Aug 8, 2017

Made a bit of progress but I need more time. The query API is tricky because it's so rich and flexible.

@sureshrag3

This comment has been minimized.

Copy link

sureshrag3 commented Oct 23, 2017

@mistercrunch - Thanks for working on this. Were you able to make any progress on this feature? We are eagerly waiting to include ES data in our dashboards :)

@mistercrunch

This comment has been minimized.

Copy link
Contributor Author

mistercrunch commented Oct 23, 2017

I made a fair amount of progress, the skeleton of the work that needs to get done is here. I'm not planning on working on this anytime soon if someone else wants to take over.

@@ -190,6 +190,7 @@
DEFAULT_MODULE_DS_MAP = OrderedDict([
('superset.connectors.sqla.models', ['SqlaTable']),
('superset.connectors.druid.models', ['DruidDatasource']),
('superset.connectors.elastic.models', ['ElasticDatasource']),

This comment has been minimized.

Copy link
@angelcervera

angelcervera Feb 2, 2018

Maybe is good don't short the name and call it .elasticsearch. and ElasticseachDatasource to avoid confusion with other future datasources.
I don't know at the moment, but maybe in the future people wants integration with other products, for example, Elastic Query from Azure.

@aboganas

This comment has been minimized.

Copy link
Contributor

aboganas commented Jun 27, 2018

is there any updates on this much needed feature?

@mistercrunch

This comment has been minimized.

Copy link
Contributor Author

mistercrunch commented Jun 28, 2018

I dropped the ball on this, fell off my priority list. If someone wants to pick up where I left off I'll be happy to chime in / review.

@aboganas

This comment has been minimized.

Copy link
Contributor

aboganas commented Jun 29, 2018

if we start a bounty for this feature, what would be a fair and reasonable price?

@davidecavestro

This comment has been minimized.

Copy link

davidecavestro commented Jun 29, 2018

@aboganas @mistercrunch please also note that ElasticSearch exposes a SQL REST API now, so maybe we can get a smoother integration
See https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-rest.html

@mistercrunch

This comment has been minimized.

Copy link
Contributor Author

mistercrunch commented Jul 1, 2018

@davidecavestro then the next step is to find or write a Python dbapi-compliant driver for ES as well as a SQLAlchemy dialect for it. @betodealmeida did just that for Druid, here's what the PR looked like: https://github.com/druid-io/pydruid/pull/110/files

The DBAPI spec is well documented and it's pretty easy to write a SQLAlchemy dialect.

@arpit-agarwal

This comment has been minimized.

Copy link
Contributor

arpit-agarwal commented Jul 7, 2018

A new PR #5358 with implementation is just got submitted

@kristw

This comment has been minimized.

Copy link
Contributor

kristw commented Jan 23, 2019

Close this in favor of #5358

@kristw kristw closed this Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.