Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _() to Exception messages #3034

Merged
merged 7 commits into from Aug 11, 2017
Merged

Conversation

roganw
Copy link
Contributor

@roganw roganw commented Jun 24, 2017

_() missing in raise Exceptions("msg")

@xrmx
Copy link
Contributor

xrmx commented Jun 25, 2017

I think that exceptions in the logs should really be the same for everyone so that we can easily grep them.

@roganw
Copy link
Contributor Author

roganw commented Jun 25, 2017

@xrmx Logging exception information are recommend to use logging.info/warning/error/...
When use raise Exception(), the exceptions will be raised to the end user's browser.

@xrmx
Copy link
Contributor

xrmx commented Jun 25, 2017

Right, then it's fine by me

@mistercrunch
Copy link
Member

LGTM except for the broken build

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.02%) to 69.32% when pulling 51f6a81 on RoganW:update_exception_msg into 0cf0860 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 69.32% when pulling 51f6a81 on RoganW:update_exception_msg into 0cf0860 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 69.32% when pulling 51f6a81 on RoganW:update_exception_msg into 0cf0860 on apache:master.

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.005%) to 69.32% when pulling 41e2563 on RoganW:update_exception_msg into 08b7e89 on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 69.32% when pulling 41e2563 on RoganW:update_exception_msg into 08b7e89 on apache:master.

@roganw
Copy link
Contributor Author

roganw commented Aug 10, 2017

@mistercrunch Done

@mistercrunch mistercrunch merged commit bd4a4c2 into apache:master Aug 11, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants