Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pass granularity from backend to frontend as ISO duration #4755
Currently the backend will pass the granularity as a string that is engine dependent, e.g, "30 seconds". I changed the backend so that an ISO 8601 duration is passed instead. This allows the frontend to handle the granularity better, eg, for the play slider.
@@ Coverage Diff @@ ## master #4755 +/- ## ========================================== - Coverage 72.38% 72.33% -0.05% ========================================== Files 205 205 Lines 15374 15394 +20 Branches 1182 1182 ========================================== + Hits 11128 11136 +8 - Misses 4243 4255 +12 Partials 3 3
Apr 6, 2018
1 check passed
pushed a commit
this pull request
Apr 8, 2018
I exported a postgres backed set of charts and dashboards to another postgres instance with this change included. It seems to work when viewing the actual chart, but when a time grain is persisted on a chart used in a dashboard I'm getting an error as such:
I was able to backfill values stored on slices.params.time_grain_sqla, to the ISO durations from here and this resolved the issue. Did I miss a migration someplace or should one be added for this?