[import csv] ensure directory exists before saving csv file #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
ensure_csv_path_exists
branch
3 times, most recently
from
a093828
to
2657299
Compare
Codecov Report
@@ Coverage Diff @@
## master #4829 +/- ##
==========================================
+ Coverage 76.91% 76.93% +0.01%
==========================================
Files 44 44
Lines 8522 8531 +9
==========================================
+ Hits 6555 6563 +8
- Misses 1967 1968 +1
Continue to review full report at Codecov.
|
john-bodley
reviewed
Apr 15, 2018
superset/utils.py
Outdated
| try: | ||
| os.makedirs(path) | ||
| except OSError as exc: | ||
| if exc.errno == errno.EEXIST and os.path.isdir(path): |
There was a problem hiding this comment.
I would negate the conditions here removing the need for the pass.
timifasubaa
force-pushed
the
ensure_csv_path_exists
branch
2 times, most recently
from
d40d5b1
to
0f389a6
Compare
|
@john-bodley Done |
john-bodley
approved these changes
Apr 16, 2018
timifasubaa
force-pushed
the
ensure_csv_path_exists
branch
2 times, most recently
from
d5277f8
to
ce1eb3a
Compare
|
@timifasubaa if you rebase your change the CI should succeed. |
timifasubaa
force-pushed
the
ensure_csv_path_exists
branch
from
ce1eb3a
to
7192327
Compare
|
@john-bodley Succeeded. Ready for merge |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
added a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users complained of the error while uploading CSV whereby the first uploading phase fails because directory does not exist. This PR adds an extra check to ensure the directory exists before saving the csv file.
Fixes #4576