Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @superset-ui/legacy-preset-chart-nvd3 #7701

Merged
merged 1 commit into from Jun 13, 2019
Merged

Update @superset-ui/legacy-preset-chart-nvd3 #7701

merged 1 commit into from Jun 13, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jun 13, 2019 •
edited

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Pulls in fix for stacked bar charts from the superset-ui library. Before, stacked bar chart value labels would not update when series were disabled/enabled

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2019-06-12 at 5 59 08 PM
Screen Shot 2019-06-12 at 5 59 18 PM

After:
Screen Shot 2019-06-12 at 5 50 48 PM
Screen Shot 2019-06-12 at 5 50 59 PM

TEST PLAN

See the results above in the screenshots when using a stacked bar chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat, @kristw, @michellethomas

@kristw kristw merged commit 0d12243 into apache:master Jun 13, 2019
@michellethomas
Copy link
Contributor

@etr2460 I noticed this change is bumping the version from 0.10.11 to 0.10.32, do you know what else will be changed with that upgrade?

@kristw
Copy link
Contributor

kristw commented Jun 19, 2019

Most of the changes from 0.10.11 to 0.10.32 does not involve the legacy-preset-chart-nvd3 package.
https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md

The monorepo version bumps from max(all package versions) so legacy-preset-chart-nvd3 jumps from 0.10.11 to 0.10.17 and 0.10.32.
https://www.npmjs.com/package/@superset-ui/legacy-preset-chart-nvd3

michellethomas pushed a commit that referenced this pull request Jun 19, 2019
@michellethomas
Update @superset-ui/legacy-preset-chart-nvd3 (#7701)
2844c17 
(cherry picked from commit 0d12243)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michellethomas
Update @superset-ui/legacy-preset-chart-nvd3 (apache#7701)
acc5dfc 
(cherry picked from commit 0d12243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etr2460 @michellethomas @kristw @mistercrunch