[Codemod] Rename react unsafe lifecycles #8143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8143 +/- ##
=========================================
+ Coverage 66.06% 66.2% +0.13%
=========================================
Files 479 479
Lines 22930 22930
Branches 2524 2524
=========================================
+ Hits 15148 15180 +32
+ Misses 7648 7616 -32
Partials 134 134
Continue to review full report at Codecov.
|
kristw
approved these changes
Sep 3, 2019
added 4 commits
September 3, 2019 11:36
…into erik-ritter--unsafe-lifecycles-codemod
…tr2460/incubator-superset into erik-ritter--unsafe-lifecycles-codemod
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Cleans up some of these console warnings:
Ran
npx react-codemod rename-unsafe-lifecyclesinsuperset/assets/srcandsuperset/assets/spec.However, we still have a decent number of dependencies that we'll need to update prior to being able to use React 17. This can be pushed off for a while (because React 17 isn't even out yet), but at some point, we'll have to pay the piper and upgrade a bunch of stuff. This'll include (I think) moving to a newer version of Bootstrap and finding a new React virtualizable library, as well as a bunch of other changes. No actions needed yet, but we'll wanna keep this on the future radar.
TEST PLAN
Ensure dashboards, charts, and SQL Lab still work as expected. CI/Tests
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @kristw @mistercrunch