Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate *_enclave.so instead of *.enclave.so #189

Merged
merged 1 commit into from Dec 21, 2019
Merged

Conversation

@rdzhou
Copy link
Contributor

rdzhou commented Dec 21, 2019

Description

  • Generate *_enclave.so instead of *.enclave.so for the convenience of symbol retrieving.
  • Remove unused env MESATEE_TEST_MODE.
  • Remove <build_dir> from target check.
  • Fix format of mesatee_core/src/lib.rs.

Type of change (select applied and DELETE the others)

  • Code cleanup or just sync with upstream third-party crates

How Has This Been Tested?

Yes

Checklist (check ALL before submitting PR, even not applicable)

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.
symbol retrieving.
Remove unused env MESATEE_TEST_MODE.
Remove <build_dir> from target `check`.
Fix format of mesatee_core/src/lib.rs.
@rdzhou rdzhou force-pushed the rdzhou:fix_enclave branch from ea8f94b to 68e9b5d Dec 21, 2019
@mssun mssun self-requested a review Dec 21, 2019
@mssun
mssun approved these changes Dec 21, 2019
Copy link
Member

mssun left a comment

LGTM. Thanks!

@mssun mssun merged commit 2d43429 into apache:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.