Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add SgxTrustedServer in RPC #194

Merged
merged 2 commits into from Dec 26, 2019
Merged

[core] Add SgxTrustedServer in RPC #194

merged 2 commits into from Dec 26, 2019

Conversation

@mssun
Copy link
Member

mssun commented Dec 25, 2019

Description

Add SgxTrustedServer in RPC.

Now, we finally have SgxTrustedChannel and SgxTrustedServer.

  • SgxTrustedChannel: RPC client side struct
  • SgxTrustedServer: RPC server side struct

Usage:

let server = SgxTrustedServer::new(ACSEnclave::default(), fd, enclave_attr)?;

// Ignore error
let _ = server.start();

Type of change (select applied and DELETE the others)

  • New API for RPC

How Has This Been Tested?

CI: https://ci.mesalock-linux.org/mssun/incubator-mesatee/257

Checklist (check ALL before submitting PR, even not applicable)

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.
mssun added 2 commits Dec 25, 2019
@mssun mssun requested a review from m4sterchain Dec 26, 2019
Copy link
Contributor

m4sterchain left a comment

Is the Pipe abstraction layer still necessary after this PR?(If we implement the RPCServer trait for SgxTrustedServer, and let the SgxTrustedServer maintain the rustls:: StreamOwned session.)

@mssun

This comment has been minimized.

Copy link
Member Author

mssun commented Dec 26, 2019

Yes, the internal abstraction needs to be refactored also. I need to read some RPC framework and design one for ours.

@m4sterchain

This comment has been minimized.

Copy link
Contributor

m4sterchain commented Dec 26, 2019

Yes, the internal abstraction needs to be refactored also. I need to read some RPC framework and design one for ours.

OK. Let's move on for future iteration.

Copy link
Contributor

m4sterchain left a comment

LGTM.

@mssun mssun merged commit ffd5d1a into apache:master Dec 26, 2019
@mssun mssun deleted the mssun:rpc branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.