Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health and Stats delay different than Traffic Monitor Java #1923

Closed
smalenfant opened this issue Feb 23, 2018 · 2 comments · Fixed by #3914
Closed

Health and Stats delay different than Traffic Monitor Java #1923

smalenfant opened this issue Feb 23, 2018 · 2 comments · Fixed by #3914
Labels
bug something isn't working as intended Traffic Monitor related to Traffic Monitor
Milestone

Comments

@smalenfant
Copy link
Contributor

In previous version of Traffic Monitor (2.1, java). The "query_time" was an indication on how long the _astats took to download.

In the Go version of Traffic Monitor, the Health and Stats is the delay to receive the header response since it is chunked.

We have cache servers that have bad NIC's which Traffic Monitor would detect even at idle speed. This doesn't show anymore.

The Health and Stats query time should include time finishing downloading the body.

@smalenfant smalenfant added the Traffic Monitor related to Traffic Monitor label Feb 23, 2018
@smalenfant smalenfant added this to the 2.3 milestone Feb 23, 2018
@smalenfant
Copy link
Contributor Author

@rob05c I tried to fix this although seems like I could not get the body transfer delay included in the Stat Time. You mind taking a look?

https://github.com/smalenfant/incubator-trafficcontrol/tree/sm-resp-time

@rob05c
Copy link
Member

rob05c commented Mar 12, 2018

The Fetcher isn't actually reading the body, it's passing the io.Reader to the Handler. The Go runtime may choose not to read it from the socket, until it's actually read from the io.Reader in the Handler.

The reqTime needs to be set right after we actually read the bytes, after this line: https://github.com/apache/incubator-trafficcontrol/blob/b3a20df3d1e6405ff530ab20b5698e700ee6da46/traffic_monitor/cache/cache.go#L308

@mitchell852 mitchell852 added the bug something isn't working as intended label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Monitor related to Traffic Monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants