Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created and tested validation rules based upon 2 new deps #1766

Merged
merged 13 commits into from Jan 19, 2018

Conversation

dewrich
Copy link
Contributor

@dewrich dewrich commented Jan 12, 2018

No description provided.

@dewrich dewrich added this to To Do in TO API Golang Rewrite via automation Jan 12, 2018
@dewrich dewrich changed the title Created and tested non-db validation rules based upon 2 new deps Created and tested validation rules based upon 2 new deps Jan 12, 2018
@asfgit
Copy link
Contributor

asfgit commented Jan 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/879/
Test PASSed.

@dangogh dangogh self-requested a review January 12, 2018 22:01
@dangogh dangogh self-assigned this Jan 12, 2018
Copy link
Member

@dangogh dangogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new dependencies will need an entry in the LICENSE file and .rat-excludes.

}

func (ds *TODeliveryService) GetType() string {
return "ds"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in the audit log, perl logs with deliveryservice should we use that instead of ds?

@asfgit
Copy link
Contributor

asfgit commented Jan 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/886/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jan 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/887/
Test PASSed.

}

func getTypeName(db *sqlx.DB, typeID int) (string, error) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need this elsewhere.. should it be a method on a go-tc struct?

@asfgit
Copy link
Contributor

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/898/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jan 18, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/899/
Test FAILed.

@dangogh dangogh merged commit 1db8679 into apache:master Jan 19, 2018
TO API Golang Rewrite automation moved this from To Do to Done Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants