Added maxmind.default.override parameter to CRConfig to handle maxmind default locations #1866
Conversation
added documentation for geolocation.default.override profile parameter
|
Can one of the admins verify this patch? |
rivasj
changed the title
rivasj
force-pushed
the
2.2.x_maxmind_default_override_3
branch
from
97aef6f
to
ba0c0ca
Compare
rivasj
force-pushed
the
2.2.x_maxmind_default_override_3
branch
2 times, most recently
from
7ff4465
to
08cc6ba
Compare
rivasj
force-pushed
the
2.2.x_maxmind_default_override_3
branch
from
08cc6ba
to
2b2a8df
Compare
| @@ -158,6 +158,9 @@ Many of the settings for the different servers in a Traffic Control CDN are cont | |||
| +--------------------------+---------------+---------------------------------------------------------------------------------------------------------------------------------------+ | |||
| | geolocation6.polling.url | CRConfig.json | The location to get the IPv6 GeoLiteCity database from. | | |||
| +--------------------------+---------------+---------------------------------------------------------------------------------------------------------------------------------------+ | |||
| | maxmind.default.override | CRConfig.json | The destination geo coordinates to use for client location when maxmind returns a default location that matches the country code. | | |||
There was a problem hiding this comment.
Can we enter more than 1 country at a time? i.e. US and Canada?
There was a problem hiding this comment.
Yes, this parameter can be specified multiple times with different values. The documentation should be updated to reflect that.
@rivasj can you update the documentation to reflect this?
There was a problem hiding this comment.
I've updated documentation to show support for multiple parameter values.
| @@ -86,6 +87,8 @@ | |||
| private final ConsistentHasher consistentHasher = new ConsistentHasher(); | |||
| private SteeringRegistry steeringRegistry; | |||
|
|
|||
| private final Map<String, Geolocation> defaultGeolocations = new HashMap<String, Geolocation>(); | |||
There was a problem hiding this comment.
nitpick, but variable might be more clear named defaultGeolocationsOverride. Skimming the code I got this confused with defaultLocation (which is what we call a geolocation from Maxmind w/o a city or postal code)
There was a problem hiding this comment.
I've renamed defaultGeolocations to defaultGeolocationsOverride
Maintain a list of country code/coordinate pairs as: CountryCode;Lat,Long - in CRConfig.json to use instead of a default location for a given country. When a default location is indicated, TR checks if that country code has an entry specified in the config. If it does, it will set the client location to use the coordinates in that entry.