Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-2524]As debugged by Arvind: Increase size of the buffer that reads cmdline… #994

Merged
merged 2 commits into from Mar 8, 2017

Conversation

uamgo
Copy link
Contributor

@uamgo uamgo commented Mar 7, 2017

… arg

Conflicts:

	core/sql/cli/CliExtern.cpp
@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-release2.1/22/

@Traf-Jenkins
Copy link

@arvind-narain
Copy link
Contributor

Looks good Kevin. Thanks for the change.
This is needed for Centos 6.8+ systems where the cmdline in /proc/ can be > 4K.

Could you please also include the following change or equivalent? This will be needed once we get over the sqInit() failure:

--- a/core/sqf/src/seabed/src/ms.cpp +++ b/core/sqf/src/seabed/src/ms.cpp @@ -1391,6 +1391,7 @@ SB_THROWS_FATAL { true, // args &lv_cmdline, lv_cmdline.size()); +#if 0 #ifdef SQ_PHANDLE_VERIFIER sprintf(&lv_line, "msg_init - p-id=%d/%d" PFVY ", tid=%ld, pname=%s, cmdline=%s, %s\n", #else @@ -1405,6 +1406,7 @@ SB_THROWS_FATAL { ga_ms_su_pname, &lv_cmdline, ms_seabed_vers()); +#endif

@DaveBirdsall
Copy link
Contributor

The change looks good. There needs to be a JIRA for this though.

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-release2.1/24/

@uamgo uamgo changed the title [Cherry-pick]As debugged by Arvind: Increase size of the buffer that reads cmdline… [TRAFODION-2524]As debugged by Arvind: Increase size of the buffer that reads cmdline… Mar 8, 2017
@uamgo
Copy link
Contributor Author

uamgo commented Mar 8, 2017

@arvind-narain Thanks! The changes has been in.
@DaveBirdsall Thanks! JIRA ID has been added.

Copy link
Contributor

@arvind-narain arvind-narain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

+1

@asfgit asfgit merged commit 8a3cfd6 into apache:release2.1 Mar 8, 2017
@uamgo uamgo deleted the a_r2.1 branch March 24, 2017 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants