Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849 #4853

Merged
merged 1 commit into from Feb 10, 2020

Conversation

Laurawly
Copy link
Contributor

In recent PR $4849, code after line 51 was mistakenly moved under the for loop in line 48, which caused problems for tile_ic and other cfg params not defined when output channel size is a multiple of 16. In this PR, we correct this change.
@comaniac @tqchen

@Laurawly Laurawly changed the title [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849 [Fix] reverse some changes made for intel_graphics/conv2d.py in PR #4849 Feb 10, 2020
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen
Copy link
Member

tqchen commented Feb 10, 2020

sorry for the oversight

@tqchen tqchen merged commit b7364b4 into apache:master Feb 10, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants