[Subtask] [Netty] Startup script supports setting MaxDirectMemory #585
Assignees
Comments
leixm
changed the title
21 tasks
jerqi
added a commit
to jerqi/incubator-uniffle
that referenced
this issue
Mar 7, 2023
jerqi
added a commit
that referenced
this issue
Mar 8, 2023
…#690) ### What changes were proposed in this pull request? Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty. ### Why are the changes needed? Fix: #585 ### Does this PR introduce _any_ user-facing change? Yes. I will add the entire document of rss-env.sh in the future. ### How was this patch tested? Manual test Co-authored-by: roryqi <roryqi@tencent.com>
zuston
added a commit
that referenced
this issue
Mar 8, 2023
zuston
added a commit
that referenced
this issue
Mar 9, 2023
jerqi
pushed a commit
that referenced
this issue
Mar 9, 2023
### What changes were proposed in this pull request?
If unset the var of `MAX_DIRECT_MEMORY_SIZE`, the error of `unbound variable` will be thrown when executing the start-shuffle-server.sh
### Why are the changes needed?
Use the ${xxx:-} to check its existence. refer to : https://bnikolic.co.uk/blog/bash-unbound-variable
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested in production env
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Mar 21, 2023
…Server (apache#690) ### What changes were proposed in this pull request? Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty. ### Why are the changes needed? Fix: apache#585 ### Does this PR introduce _any_ user-facing change? Yes. I will add the entire document of rss-env.sh in the future. ### How was this patch tested? Manual test Co-authored-by: roryqi <roryqi@tencent.com>
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this issue
Mar 21, 2023
…er.sh
### What changes were proposed in this pull request?
If unset the var of `MAX_DIRECT_MEMORY_SIZE`, the error of `unbound variable` will be thrown when executing the start-shuffle-server.sh
### Why are the changes needed?
Use the ${xxx:-} to check its existence. refer to : https://bnikolic.co.uk/blog/bash-unbound-variable
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested in production env
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this issue
Apr 5, 2023
…Server (apache#690) ### What changes were proposed in this pull request? Add MaxDirectMemorySize option for shuffle Server. It will be convenient for Netty. ### Why are the changes needed? Fix: apache#585 ### Does this PR introduce _any_ user-facing change? Yes. I will add the entire document of rss-env.sh in the future. ### How was this patch tested? Manual test Co-authored-by: roryqi <roryqi@tencent.com>
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this issue
Apr 5, 2023
…er.sh
### What changes were proposed in this pull request?
If unset the var of `MAX_DIRECT_MEMORY_SIZE`, the error of `unbound variable` will be thrown when executing the start-shuffle-server.sh
### Why are the changes needed?
Use the ${xxx:-} to check its existence. refer to : https://bnikolic.co.uk/blog/bash-unbound-variable
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested in production env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the subtask
The startup script supports setting Xmx and MaxDirectMemory according to whether netty is enabled.
The document link address is as follows:
https://docs.google.com/document/d/1srlBlLpJ3hbzd8ru5QaY5aCSLR9M2ttHXmlvcFC-SLg/edit?usp=sharing
Parent issue
#133
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: