Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Replace HashSet with ImmutableSet in configs #195

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Sep 1, 2022

What changes were proposed in this pull request?

Replace HashSet with ImmutableSet in RssMRConfigs and RssSparkConfigs.

Why are the changes needed?

It's error prone to use mutable collection in public static fields.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@jerqi jerqi requested a review from frankliee September 1, 2022 07:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #195 (3f91548) into master (d931e8b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #195      +/-   ##
============================================
- Coverage     58.40%   58.36%   -0.04%     
+ Complexity     1273     1271       -2     
============================================
  Files           158      158              
  Lines          8446     8448       +2     
  Branches        784      784              
============================================
- Hits           4933     4931       -2     
- Misses         3260     3263       +3     
- Partials        253      254       +1     
Impacted Files Coverage Δ
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java 75.00% <100.00%> (+8.33%) ⬆️
.../java/org/apache/spark/shuffle/RssSparkConfig.java 96.66% <100.00%> (ø)
...storage/handler/impl/DataSkippableReadHandler.java 81.25% <0.00%> (-3.13%) ⬇️
...org/apache/uniffle/server/ShuffleFlushManager.java 76.66% <0.00%> (-1.67%) ⬇️
...apache/uniffle/coordinator/ApplicationManager.java 83.82% <0.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fail test case is unrelated to this pr. LGTM, thanks @kaijchen ,merged.

@jerqi jerqi merged commit 331ebb2 into apache:master Sep 2, 2022
@kaijchen kaijchen deleted the immutable branch January 18, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants