Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-48][FEATURE][FOLLOW UP] add unit test for validating rss objects #248

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

wangao1236
Copy link
Collaborator

What changes were proposed in this pull request?

For issue #48
I add some unit test about validating rss objects in webhook components.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@wangao1236 wangao1236 force-pushed the feat-open-source branch 6 times, most recently from 795ee21 to 3f2990f Compare September 28, 2022 13:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #248 (3f2990f) into master (7eb069e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
- Coverage     59.29%   59.25%   -0.04%     
+ Complexity     1346     1344       -2     
============================================
  Files           162      162              
  Lines          8789     8789              
  Branches        828      828              
============================================
- Hits           5211     5208       -3     
- Misses         3311     3313       +2     
- Partials        267      268       +1     
Impacted Files Coverage Δ
...org/apache/uniffle/server/ShuffleFlushManager.java 76.66% <0.00%> (-1.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 4408359 into apache:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants