Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the log of incorrectly bound class #35

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

wForget
Copy link
Member

@wForget wForget commented Jul 6, 2022

What changes were proposed in this pull request?

Fix the log of incorrectly bound class.

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #35 (41a5f98) into master (150fa4d) will increase coverage by 0.83%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     56.80%   57.63%   +0.83%     
+ Complexity     1203     1102     -101     
============================================
  Files           152      141      -11     
  Lines          8401     7363    -1038     
  Branches        813      712     -101     
============================================
- Hits           4772     4244     -528     
+ Misses         3370     2886     -484     
+ Partials        259      233      -26     
Impacted Files Coverage Δ
.../storage/handler/impl/MemoryClientReadHandler.java 0.00% <0.00%> (ø)
.../uniffle/storage/handler/impl/LocalFileReader.java 54.54% <100.00%> (ø)
...rg/apache/hadoop/mapred/RssMapOutputCollector.java
...java/org/apache/hadoop/mapred/SortWriteBuffer.java
...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java
.../java/org/apache/hadoop/mapreduce/RssMRConfig.java
...pache/hadoop/mapreduce/task/reduce/RssFetcher.java
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
...g/apache/hadoop/mapred/SortWriteBufferManager.java
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150fa4d...41a5f98. Read the comment docs.

@frankliee
Copy link
Contributor

Thanks for your contribution.
LGTM.

@frankliee frankliee merged commit cda31ec into apache:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants